Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backend implementation of mentions #226

Merged
merged 46 commits into from
Jul 17, 2021
Merged

Backend implementation of mentions #226

merged 46 commits into from
Jul 17, 2021

Conversation

JonasMuehlmann
Copy link
Owner

@JonasMuehlmann JonasMuehlmann commented Jul 6, 2021 •
edited
Loading

Before this PR can be merged, the following checkboxes have to be ticked

  • This code belongs to the backend and is tested, or tests are not useful
  • New functions with more than 5 lines have docstrings
  • New code has been integrated with the MessengerService if appropiate
  • New code has been integrated with the SignalRService if appropiate
  • New functions or classes have been documented in the Entwurfsdokumentation
  • Changes introduce no commented out code or Console.Writeline() statements used for debugging

Related issues:

@JonasMuehlmann
feat(Core): add MentionTargets.cs
eda44c4
@JonasMuehlmann
feat(MentionTargets): add target message and replace team with …
136c17e 
…`all`
@JonasMuehlmann
feat(MentionService): add method to create mention
1672f72
@JonasMuehlmann
feat(MentionService): add method to remove mention
a5d60ae
@JonasMuehlmann
fix: provide proper mechanism to use production/test DB
9c1cb01
@JonasMuehlmann
fix(MentionService): fix syntax error in SQL query
1513b2d
@JonasMuehlmann
test(MentionService): add basic tests for create and remove
aa23ed2
@JonasMuehlmann
feat(MentionService): add method to retrieve mentions
7832302
@JonasMuehlmann
feat(Mapper): Add mapper for Mention
cfccc3c
@JonasMuehlmann
feat(Model): add model for mention
f64668f
@JonasMuehlmann
fix(Mapper): fix mapper for mention
fd9b5c9
@JonasMuehlmann
feat(MentionService): partial implementation of method to resolve m…
7050487 
…ention ids in messages
@JonasMuehlmann
fix(MentionServiceTest): fix missing initialization of `mentionServ…
051b883 
…ice`
@JonasMuehlmann JonasMuehlmann linked an issue Jul 6, 2021 that may be closed by this pull request
Implementation of ability to mention/reference entities in messages #207
Open
8 tasks
@JonasMuehlmann JonasMuehlmann changed the title Mentions Backend implementation of mentions Jul 6, 2021
JonasMuehlmann and others added 14 commits July 8, 2021 10:05
@JonasMuehlmann
Merge branch 'unstable' into mentions
8f0af2f
@JonasMuehlmann
Merge branch 'unstable' into mentions
f5806e1
@JonasMuehlmann
fix(MessageService): fix merge error in RetrieveMessage()
57f8c3a
@JonasMuehlmann
fix: fix merge error in test files
7a8a634
@JonasMuehlmann
feat(TeamService): add method to retrieve single role from id
68139e2
@JonasMuehlmann
feat(MentionService): extend ResolveMentions()
78126be
@JonasMuehlmann
Merge branch 'unstable' into mentions
de5f1c2
@JonasMuehlmann
Merge branch 'mentions' of https://github.com/JonasMuehlmann/BIB_VPR …
c86f9d8 
…into mentions
@JonasMuehlmann
feat(Models): add Mentionable model
b9c20a3
@JonasMuehlmann
feat(Mapper): add mapper for Mentionable
a2cc98c
@JonasMuehlmann
feat(MentionSerbice): add method to search mentionables
1e26e4f
@JonasMuehlmann
feat(MentionSerbice): add method to search users
f28af55
@JonasMuehlmann
feat(MentionSerbice): add method to search roles
888227a
@JonasMuehlmann
feat(MentionSerbice): add method to search channels
af3f821
@JonasMuehlmann
feat(MentionSerbice): add method to search messages
8104195
@JonasMuehlmann
fix(MentionService): fix syntax errors
7cdc4a2
@JonasMuehlmann
!fix(MentionService): filter search for mentionables by team with n…
e03c735 
…ew parameter `teamId`
@JonasMuehlmann
refactor(MentionService): make all methods static
9289a66
@JonasMuehlmann
test(MentionService): add more tests for ResolveMentions()
69d4a78
@JonasMuehlmann
Merge remote-tracking branch 'origin' into mentions
c75cf27
@JonasMuehlmann
Merge branch 'unstable' into mentions
c9b9331
@JonasMuehlmann
fix(MentionService): fix use of this in logging code
518bba6
@JonasMuehlmann
fix(MentionService): fix regex and add logging to ResolveMentions()
4d4e556
@JonasMuehlmann
fix(MentionService): fix some errors in queries used for searching …
270213c 
…mentionables
@JonasMuehlmann
fix(MentionService): add missing else branch in `SearchMentionabl…
6907185 
…es()`
@JonasMuehlmann
fix(MentionService): fix some errors in queries used for searching …
3980605 
…mentionables
@JonasMuehlmann
test(MentionService): add test for searching users
7c7ef03
@JonasMuehlmann
test(MentionService): add test for searching roles
9237bcf
@JonasMuehlmann
test(MentionService): add test for searching channels
4ca3200
@JonasMuehlmann
test(MentionService): add test for searching messages
695dea5
@JonasMuehlmann
fix(MentionService): fix some errors in queries used for searching …
fccd580 
…mentionable messages
@JonasMuehlmann JonasMuehlmann added status: review_phase Implementation is finished, except for potential feedback and removed status: in development labels Jul 16, 2021
@JonasMuehlmann JonasMuehlmann requested a review from JayKim94 July 16, 2021 11:11
@JonasMuehlmann JonasMuehlmann enabled auto-merge July 17, 2021 11:26
@JonasMuehlmann JonasMuehlmann merged commit 17218a2 into unstable Jul 17, 2021
@JonasMuehlmann JonasMuehlmann deleted the mentions branch August 4, 2021 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JayKim94 JayKim94 JayKim94 approved these changes

Assignees
No one assigned
Labels
status: review_phase Implementation is finished, except for potential feedback
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implementation of ability to mention/reference entities in messages
2 participants
@JonasMuehlmann @JayKim94